Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update django-simple-history package version #1140

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Jul 27, 2023

During the attempt to upgrade history package in the edx-platform repo, the check-migrations-test encountered a failure with new migrations. The updated package includes some enhancements that introduce new migrations. However, these migrations do not involve any alterations to the existing fields; instead, they are focused on meta changes aimed at improving the ordering functionality e.g options={'get_latest_by': ('history_date', 'history_id'

https://django-simple-history.readthedocs.io/en/latest/#section-1
Upgrading the package to 3.1.1

While try to upgrade this package in edx-platform it generates lots of migrations in /edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/enterprise/migrations

These are due to the package. Related PR jazzband/django-simple-history#862 ( this pr shows the get_latest_by usage )

Similar PR merged in credentials

@UsamaSadiq UsamaSadiq force-pushed the update-django-history-version branch from d1d4465 to 64aa112 Compare July 27, 2023 16:47
@UsamaSadiq UsamaSadiq marked this pull request as ready for review July 27, 2023 16:57
@awais786 awais786 force-pushed the update-django-history-version branch from c24af42 to 2173330 Compare July 28, 2023 15:23
@UsamaSadiq UsamaSadiq merged commit 8b75aa7 into master Aug 8, 2023
15 checks passed
@UsamaSadiq UsamaSadiq deleted the update-django-history-version branch August 8, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants